Add Tuya remote TS0042 and TS0043 variants #3368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3368 +/- ##
==========================================
+ Coverage 88.49% 88.51% +0.01%
==========================================
Files 305 305
Lines 9621 9636 +15
==========================================
+ Hits 8514 8529 +15
Misses 1107 1107 ☔ View full report in Codecov by Sentry. |
robertcsakany
changed the title
robertcsakany
changed the title
TheJulianJES
changed the title
Comment on lines
+296
to
+303
| device_automation_triggers = { | ||
| (SHORT_PRESS, BUTTON_1): {ENDPOINT_ID: 1, COMMAND: SHORT_PRESS}, | ||
| (LONG_PRESS, BUTTON_1): {ENDPOINT_ID: 1, COMMAND: LONG_PRESS}, | ||
| (DOUBLE_PRESS, BUTTON_1): {ENDPOINT_ID: 1, COMMAND: DOUBLE_PRESS}, | ||
| (SHORT_PRESS, BUTTON_2): {ENDPOINT_ID: 2, COMMAND: SHORT_PRESS}, | ||
| (LONG_PRESS, BUTTON_2): {ENDPOINT_ID: 2, COMMAND: LONG_PRESS}, | ||
| (DOUBLE_PRESS, BUTTON_2): {ENDPOINT_ID: 2, COMMAND: DOUBLE_PRESS}, | ||
| } |
There was a problem hiding this comment.
If they are the same as other triggers, we could just do
device_automation_triggers = TuyaSmartRemote0042TOPlusA.device_automation_triggersThis is also fine though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fixes #3367
As desribed in #668 and #663 custom quirks is required to support the following models:
A Tuya zigbee remote 2-button one TS0042 & a 3-button one TS0043. I could connected them to ZHA but they could not match the Tuya quirks.
Additional information
Checklist
pre-commitchecks pass / the code has been formatted using Black