Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new zigpy ZCL attribute data types #3324

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Aug 28, 2024

Proposed change

Make quirks (just unit tests) compatible with zigpy/zigpy#1463. It's a relatively simple change that affects just how ZCL data types are looked up.

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@puddly puddly marked this pull request as ready for review August 28, 2024 15:00
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.48%. Comparing base (156aaa6) to head (b4df879).
Report is 10 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3324      +/-   ##
==========================================
+ Coverage   88.25%   88.48%   +0.22%     
==========================================
  Files         302      305       +3     
  Lines        9434     9621     +187     
==========================================
+ Hits         8326     8513     +187     
  Misses       1108     1108              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puddly puddly mentioned this pull request Aug 28, 2024
3 tasks
@dmulcahey dmulcahey merged commit 4c3729b into zigpy:dev Aug 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants