Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuya cover _TZE200_1vxgqfba #3277

Merged
merged 2 commits into from
Aug 3, 2024
Merged

Add Tuya cover _TZE200_1vxgqfba #3277

merged 2 commits into from
Aug 3, 2024

Conversation

kdober
Copy link
Contributor

@kdober kdober commented Aug 1, 2024

Proposed change

This modification add supports for Zemismart roller motor ZM25R1 (TZE200_1vxgqfba)

Additional information

It solves issue #2560
Fix #2560
Modification consist on the addition of a new model into existent functions. No mayor change exist
It was tested on my HA with a custom ZHA quirk and cover was recognized and works just fine.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

This modification add supports for Zemismart roller motor ZM25R1 (issue zigpy#2560).
It was tested on my HA with a custom ZHA quirk and cover works just fine.
Update ts0601_cover.py (support for Cover TZE200_1vxgqfba)
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.18%. Comparing base (e3c115e) to head (e00d4f9).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3277   +/-   ##
=======================================
  Coverage   88.18%   88.18%           
=======================================
  Files         301      301           
  Lines        9412     9412           
=======================================
  Hits         8300     8300           
  Misses       1112     1112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES changed the title Update ts0601_cover.py (support for Cover TZE200_1vxgqfba) Add Tuya cover _TZE200_1vxgqfba Aug 3, 2024
@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Aug 3, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES merged commit 915ff9b into zigpy:dev Aug 3, 2024
6 checks passed
danielp370 pushed a commit to danielp370/zha-device-handlers that referenced this pull request Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Device Support Request] Tuya - ts0601-TZE200_1vxgqfba
2 participants