Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuya soil sensor variant _TZE204_myd45weu #3173

Merged
merged 1 commit into from
May 28, 2024
Merged

Add Tuya soil sensor variant _TZE204_myd45weu #3173

merged 1 commit into from
May 28, 2024

Conversation

oneofsix
Copy link
Contributor

@oneofsix oneofsix commented May 27, 2024

Proposed change

Add Tuya soil sensor variant _TZE204_myd45weu

Additional information

Received a new version of a Tuya soil sensor currently not supported

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.14%. Comparing base (21dd8eb) to head (b8bea22).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3173   +/-   ##
=======================================
  Coverage   88.14%   88.14%           
=======================================
  Files         299      299           
  Lines        9389     9389           
=======================================
  Hits         8276     8276           
  Misses       1113     1113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label May 28, 2024
@TheJulianJES TheJulianJES changed the title Add Tuya soil sensor variant _TZE204_myd45weu Add Tuya soil sensor variant _TZE204_myd45weu May 28, 2024
@TheJulianJES TheJulianJES merged commit 4d24b70 into zigpy:dev May 28, 2024
6 checks passed
@cutzenfriend
Copy link

Doesn't work. I have this Zigbee Soil Sensor and after adding the custom quirk it just shows "Unknown" for every sensor. Model ist: QT-07S recognized as: TZE204_myd45weu with ZHA

Bildschirmfoto 2024-06-03 um 10 42 58

@oneofsix
Copy link
Contributor Author

oneofsix commented Jun 3, 2024

@cutzenfriend For my model all sensors including battery are supported.

IMG_4488
IMG_4489

@oneofsix
Copy link
Contributor Author

oneofsix commented Jun 3, 2024

@cutzenfriend your model is showing up an humidity sensor as well, which mine does not have. I’ve just added the model which supports temperature and soil moisture.

@cutzenfriend
Copy link

Hi, removed the quirk and restarted the device multiple times. Now it works. Sorry for the trouble :)

xbezdick pushed a commit to xbezdick/zha-device-handlers that referenced this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants