Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit settings and fix lint issues #3034

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Conversation

dmulcahey
Copy link
Collaborator

Proposed change

This pull request includes changes to multiple files, primarily focusing on updating dependencies, improving code quality, and changing the Python version requirement. The most significant changes include updating the versions of dependencies in .pre-commit-config.yaml, changing the required Python version in pyproject.toml, and removing unnecessary methods and changing the formatting of code in several test files.

Additional information

Dependency updates:

  • .pre-commit-config.yaml: Updated the versions of codespell-project/codespell, pre-commit/mirrors-mypy, and astral-sh/ruff-pre-commit. Removed dependencies asottile/pyupgrade, PyCQA/autoflake, psf/black, pycqa/flake8, PyCQA/isort, and charliermarsh/ruff-pre-commit.

Python version changes:

  • pyproject.toml: Changed the required Python version from 3.8 to 3.12.

Code quality improvements:

Other changes:

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 89.01099% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 87.86%. Comparing base (851e050) to head (9ce2760).

Files Patch % Lines
zhaquirks/xiaomi/mija/sensor_switch.py 0.00% 5 Missing ⚠️
zhaquirks/tuya/__init__.py 71.42% 2 Missing ⚠️
zhaquirks/xiaomi/aqara/motion_ac01.py 33.33% 2 Missing ⚠️
zhaquirks/siglis/zigfred.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3034      +/-   ##
==========================================
+ Coverage   87.84%   87.86%   +0.01%     
==========================================
  Files         301      301              
  Lines        9224     9219       -5     
==========================================
- Hits         8103     8100       -3     
+ Misses       1121     1119       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmulcahey dmulcahey merged commit 86fafd6 into dev Mar 12, 2024
6 checks passed
@dmulcahey dmulcahey deleted the dm/update-ci-part-2 branch March 12, 2024 16:50
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
* update ci config

* settings for IDE plugins

* fix lint issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants