Add Conecto TS0601 _TZE200_zppcgbdj temperature & humidity
#3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The device is a Tuya rebrand, and the quirk is almost identical to one of the existing Tuya quirks (but with a different humidity multiplier).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3026 +/- ##
=======================================
Coverage 87.86% 87.86%
=======================================
Files 301 301
Lines 9219 9222 +3
=======================================
+ Hits 8100 8103 +3
Misses 1119 1119 ☔ View full report in Codecov by Sentry. |
javicalle
suggested changes
Mar 14, 2024
|
The quirk is fine in general. Just some minor comments. |
|
Agreed, and implemented as suggested. |
TheJulianJES
approved these changes
Mar 20, 2024
lgraf
pushed a commit
to lgraf/zha-device-handlers
that referenced
this pull request
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The device is a rebranded Tuya temperature and humidity sensor, and the quirk is almost identical to one of the existing Tuya quirks (but with a different humidity multiplier). I am not sure if the device is also sold under other brand names, though I suppose that is quite likely. I figure it makes sense to put it in as a Tuya quirk.
Proposed change
This pull request adds the quirk immediately after the most similar existing quirk. It is almost identical, though if follows the standard set by the rest of the file when it comes to humidity multiplier (commented line containing the default value of 100).
Additional information
Fixes #3024
I do not have the development environment available to run formatting or adding tests. Given that this is essentially a copy-paste of the quirk before it, and it works in manual testing, I hope that is OK.
Checklist
pre-commitchecks pass / the code has been formatted using Black