Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuya cover TS0601 _TZE200_9vpe3fl1 variant #3021

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

lucasfeijo
Copy link
Contributor

@lucasfeijo lucasfeijo commented Mar 4, 2024

Proposed change

Adds support for Zemismart Roller Shade Motor _TZE200_9vpe3fl1 variant.

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.85%. Comparing base (e4d0663) to head (fa17caf).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3021   +/-   ##
=======================================
  Coverage   87.85%   87.85%           
=======================================
  Files         301      301           
  Lines        9217     9217           
=======================================
  Hits         8098     8098           
  Misses       1119     1119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucasfeijo
Copy link
Contributor Author

I'm trying to test this locally btw

@lucasfeijo
Copy link
Contributor Author

lucasfeijo commented Mar 4, 2024

Seems to be working perfectly now.

Look, I'm not sure if this is related to the zigbee pairing, but the motor runs on its own sometimes, but this also happened before I even started working with zha quirks, maybe it's deffective.

Copy link
Collaborator

@javicalle javicalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need to add the device in both quirks?
(TuyaZemismartSmartCover0601 and TuyaZemismartSmartCover0601_3)

@lucasfeijo
Copy link
Contributor Author

@javicalle (I'm new to this btw) I own another zemismart motor whose model ID is also featured in those two quirks, so I thought I'd follow the pattern. Does that seem wrong? Btw, when I run this locally the motor choses TuyaZemismartSmartCover0601_3.

@javicalle
Copy link
Collaborator

IMHO it would be better just to add it to the needed quirk.
If you have tested it locally, LGTM.

Thanks for your contribution.

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Mar 8, 2024
@lucasfeijo
Copy link
Contributor Author

@javicalle I removed the RF remote pairing and it's not misbehaving anymore, must've been interference. The quirk has been working flawlessly ever since. This can be merged.

Copy link
Collaborator

@javicalle javicalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks.

Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES merged commit f588644 into zigpy:dev Mar 18, 2024
14 checks passed
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants