Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tuya 3 gang switch TS0601 _TZE200_vhy3iakz #3004

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

rasmus-hagberg
Copy link
Contributor

Proposed change

Mark the TS0601 _TZE200_vhy3iakz device as a 3 gang switch instead of a 1 gang switch.

Additional information

I purchased a 3 gang "Tuya Smart ZigBee Push Switch" from here. In HA the manufacturer is "_TZE200_vhy3iakz" and the model is "TS0601". It uses the ts0601_switch.TuyaSingleSwitchTO quirk, and so I was only able to control the first switch.

Multi gang quirks for tuya switches were added in this PR, which notes that "For those devices whose number of gangs is not clear, they have been defined as 1-gang devices until someone report correct info" and "we have doubts about [the _TZE200_vhy3iakz] device".

I tried the changes by loading them as a custom quirk, and it works fine for me. I am now able to control all three switches remotely, and the status is updated properly in HA.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

_TZE200_vhy3iakz is a 3 gang switch, not a 1 gang switch
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.85%. Comparing base (fc1e55f) to head (3c6c7fe).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3004   +/-   ##
=======================================
  Coverage   87.85%   87.85%           
=======================================
  Files         301      301           
  Lines        9217     9217           
=======================================
  Hits         8098     8098           
  Misses       1119     1119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES changed the title Mark TS0601 _TZE200_vhy3iakz as 3 gang Fix Tuya 3 gang switch TS0601 _TZE200_vhy3iakz Feb 26, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES added Tuya Request/PR regarding a Tuya device bugfix This PR fixes a bug labels Feb 26, 2024
@TheJulianJES TheJulianJES merged commit cc74433 into zigpy:dev Feb 26, 2024
14 checks passed
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
Move `_TZE200_vhy3iakz` to correct quirk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR fixes a bug Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants