Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues in compare function after code rebase #16

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Fix issues in compare function after code rebase #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba6626f
Revert "update compare functions"
PHILO-HE Jul 14, 2023
f50b9ef
Fix issues and refactor code
PHILO-HE Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 14 additions & 30 deletions velox/functions/sparksql/Comparisons.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,42 +43,26 @@ class ComparisonFunction final : public exec::VectorFunction {
VectorPtr& result) const override {
context.ensureWritable(rows, BOOLEAN(), result);
auto* flatResult = result->asFlatVector<bool>();
flatResult->mutableRawValues<uint64_t>();
const Cmp cmp;
if (args[0]->isFlatEncoding() && args[1]->isFlatEncoding()) {
// Fast path for (flat, flat).
auto flatA = args[0]->asUnchecked<FlatVector<T>>();
auto rawA = flatA->mutableRawValues();
auto flatB = args[1]->asUnchecked<FlatVector<T>>();
auto rawB = flatB->mutableRawValues();
rows.applyToSelected([&](vector_size_t i) {

exec::DecodedArgs decodedArgs(rows, args, context);
auto decodedArg0 = decodedArgs.at(0);
auto decodedArg1 = decodedArgs.at(1);
if (decodedArg0->isIdentityMapping() && decodedArg1->isConstantMapping()) {
rows.applyToSelected([&](auto i) {
flatResult->set(
i, cmp(rawA[i], rawB[i]));
});
} else if (args[0]->isConstantEncoding() && args[1]->isFlatEncoding()) {
// Fast path for (const, flat).
auto constant = args[0]->asUnchecked<SimpleVector<T>>()->valueAt(0);
auto flatValues = args[1]->asUnchecked<FlatVector<T>>();
auto rawValues = flatValues->mutableRawValues();
rows.applyToSelected([&](vector_size_t i) {
flatResult->set(i, cmp(constant, rawValues[i]));
i, cmp(decodedArg0->valueAt<T>(i), decodedArg1->valueAt<T>(0)));
});
} else if (args[0]->isFlatEncoding() && args[1]->isConstantEncoding()) {
// Fast path for (flat, const).
auto flatValues = args[0]->asUnchecked<FlatVector<T>>();
auto constant = args[1]->asUnchecked<SimpleVector<T>>()->valueAt(0);
auto rawValues = flatValues->mutableRawValues();
rows.applyToSelected([&](vector_size_t i) {
flatResult->set(i, cmp(rawValues[i], constant));
} else if (
decodedArg0->isConstantMapping() && decodedArg1->isIdentityMapping()) {
rows.applyToSelected([&](auto i) {
flatResult->set(
i, cmp(decodedArg0->valueAt<T>(0), decodedArg1->valueAt<T>(i)));
});
} else {
// Fast path if one or more arguments are encoded.
exec::DecodedArgs decodedArgs(rows, args, context);
auto decoded0 = decodedArgs.at(0);
auto decoded1 = decodedArgs.at(1);
rows.applyToSelected([&](vector_size_t i) {
rows.applyToSelected([&](auto i) {
flatResult->set(
i, cmp(decoded0->valueAt<T>(i), decoded1->valueAt<T>(i)));
i, cmp(decodedArg0->valueAt<T>(i), decodedArg1->valueAt<T>(i)));
});
}
}
Expand Down
Loading