feat(plugin-chart-echarts): subject add sort by metric for Pie Chart (a…

…pache#946)
zhaoyongjie · Nov 24, 2021 · e2554b3 · e2554b3
1 parent 477fb7b
commit e2554b3
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/...tend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Pie/buildQuery.ts b/...tend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Pie/buildQuery.ts
@@ -19,11 +19,11 @@
 import { buildQueryContext, QueryFormData } from '@superset-ui/core';
 
 export default function buildQuery(formData: QueryFormData) {
-  const { metric } = formData;
+  const { metric, sort_by_metric } = formData;
   return buildQueryContext(formData, baseQueryObject => [
     {
       ...baseQueryObject,
-      orderby: [[metric, false]],
+      ...(sort_by_metric && { orderby: [[metric, false]] }),
     },
   ]);
 }
diff --git a/...d/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx b/...d/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx
@@ -44,7 +44,22 @@ const config: ControlPanelConfig = {
     {
       label: t('Query'),
       expanded: true,
-      controlSetRows: [['groupby'], ['metric'], ['adhoc_filters'], ['row_limit']],
+      controlSetRows: [
+        ['groupby'],
+        ['metric'],
+        ['adhoc_filters'],
+        ['row_limit'],
+        [
+          {
+            name: 'sort_by_metric',
+            config: {
+              type: 'CheckboxControl',
+              label: t('Sort by metric'),
+              description: t('Whether to sort results by the selected metric in descending order.'),
+            },
+          },
+        ],
+      ],
     },
     {
       label: t('Chart Options'),