chore(plugin-chart-echarts): rename boxplot type to whisker_type (apa…

…che#804)
zhaoyongjie · Nov 17, 2021 · b5719c8 · b5719c8
1 parent d89270e
commit b5719c8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/.../temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/BoxPlot/buildQuery.ts b/.../temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/BoxPlot/buildQuery.ts
@@ -17,7 +17,7 @@
  * under the License.
  */
 import { buildQueryContext, convertMetric } from '@superset-ui/core';
-import { BoxPlotQueryFormData, BoxPlotQueryObjectType } from './types';
+import { BoxPlotQueryFormData, BoxPlotQueryObjectWhiskerType } from './types';
 
 const PERCENTILE_REGEX = /(\d+)\/(\d+) percentiles/;
 
@@ -27,20 +27,19 @@ export default function buildQuery(formData: BoxPlotQueryFormData) {
   // @ts-ignore
   const metrics = formDataMetrics.map(metric => convertMetric(metric).label);
   return buildQueryContext(formData, baseQueryObject => {
-    let type: BoxPlotQueryObjectType;
+    let whiskerType: BoxPlotQueryObjectWhiskerType;
     let percentiles: [number, number] | undefined;
     const percentileMatch = PERCENTILE_REGEX.exec(whiskerOptions as string);
     const distributionColumns = columns || [];
 
-    if (whiskerOptions === 'Tukey') type = 'tukey';
-    else if (whiskerOptions === 'Min/max (no outliers)') type = 'min/max';
+    if (whiskerOptions === 'Tukey') whiskerType = 'tukey';
+    else if (whiskerOptions === 'Min/max (no outliers)') whiskerType = 'min/max';
     else if (percentileMatch) {
-      type = 'percentile';
+      whiskerType = 'percentile';
       percentiles = [parseInt(percentileMatch[1], 10), parseInt(percentileMatch[2], 10)];
     } else {
       throw new Error(`Unsupported whisker type: ${whiskerOptions}`);
     }
-    console.log(formData);
     return [
       {
         ...baseQueryObject,
@@ -50,7 +49,7 @@ export default function buildQuery(formData: BoxPlotQueryFormData) {
           {
             operation: 'boxplot',
             options: {
-              type,
+              whisker_type: whiskerType,
               percentiles,
               groupby,
               metrics,

diff --git a/...ntend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/BoxPlot/types.ts b/...ntend/temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/BoxPlot/types.ts
@@ -32,4 +32,4 @@ export type BoxPlotFormDataWhiskerOptions =
 
 export type BoxPlotFormXTickLayout = '45°' | '90°' | 'auto' | 'flat' | 'staggered';
 
-export type BoxPlotQueryObjectType = 'tukey' | 'min/max' | 'percentile';
+export type BoxPlotQueryObjectWhiskerType = 'tukey' | 'min/max' | 'percentile';