fix: do not submit pending hash to tracker to avoid invalid hash

[ws4charlie]

Description

Cherry picked minimum fix from the PR:

• on 20-min timeout, do not submit pending outbound tx hash to tracker to avoid invalid hash.
• print log if outbound tracker is detected full of hashes.

How Has This Been Tested?

• Tested CCTX in localnet
• Tested in development environment
• Go unit tests
• Go integration tests
• Tested via GitHub Actions

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[lumtis]

The tracker is not added at all, we'll need to add it manually?

[lumtis]

Approving as I don't see anything concerning

[brewmaster012]

The tracker is not added at all, we'll need to add it manually?

a separate program is monitoring pending cctx and fill in missing tracker using etherscan API.
Longer term, this functionality can be merged into zetaclient if an etherscan API is provided.

[morde08]

The tracker is not added at all, we'll need to add it manually?

a separate program is monitoring pending cctx and fill in missing tracker using etherscan API. Longer term, this functionality can be merged into zetaclient if an etherscan API is provided.

It's not just etherscan though right? We'd also need Polygonscan, BSCscan, Basescan, etc. We would need one for every chain we support.

[brewmaster012]

The tracker is not added at all, we'll need to add it manually?

a separate program is monitoring pending cctx and fill in missing tracker using etherscan API. Longer term, this functionality can be merged into zetaclient if an etherscan API is provided.

It's not just etherscan though right? We'd also need Polygonscan, BSCscan, Basescan, etc. We would need one for every chain we support.

yes, etherscan API is one possible solution, but is just an example of a "indexer" that provides missing RPC calls from Eth JSON-RPC: namely the query txhash by from address & nonce. Alternatively, each zetaclient can index by themselves.