feat(zetaclient)!: Add support for EIP-1559 gas fees #2634
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughWalkthroughThe recent changes implement support for EIP-1559 gas fees within the ZetaClient, enhancing transaction fee management through a more sophisticated structure. This update includes the addition of a dedicated Gas struct for handling gas parameters and improvements to related functionalities, focusing on robust and clear processing of cross-chain transactions. The modifications signify a strategic shift towards modernizing transaction handling to comply with evolving blockchain standards. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ZetaClient
participant EVM
User->>ZetaClient: Prepare EIP-1559 Transaction
ZetaClient->>EVM: Sign Transaction with Gas Struct
EVM->>ZetaClient: Transaction Signed
ZetaClient->>User: Transaction Confirmation
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
swift1337
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2634 +/- ##
===========================================
+ Coverage 70.55% 70.63% +0.07%
===========================================
Files 335 336 +1
Lines 18373 18453 +80
===========================================
+ Hits 12963 13034 +71
- Misses 4824 4829 +5
- Partials 586 590 +4
|
swift1337
requested review from
brewmaster012,
kingpinXD,
lumtis,
ws4charlie,
skosito and
fbac
as code owners
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (7)
- changelog.md (1 hunks)
- zetaclient/chains/evm/signer/gas.go (1 hunks)
- zetaclient/chains/evm/signer/gas_test.go (1 hunks)
- zetaclient/chains/evm/signer/outbound_data.go (2 hunks)
- zetaclient/chains/evm/signer/outbound_data_test.go (1 hunks)
- zetaclient/chains/evm/signer/signer.go (23 hunks)
- zetaclient/chains/evm/signer/signer_test.go (10 hunks)
Additional context used
Path-based instructions (6)
zetaclient/chains/evm/signer/gas.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.zetaclient/chains/evm/signer/outbound_data_test.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.zetaclient/chains/evm/signer/gas_test.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.zetaclient/chains/evm/signer/outbound_data.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.zetaclient/chains/evm/signer/signer_test.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.zetaclient/chains/evm/signer/signer.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.
Learnings (1)
zetaclient/chains/evm/signer/signer_test.go (3)
Learnt from: ws4charlie PR: zeta-chain/node#2411 File: zetaclient/orchestrator/chain_activate.go:116-181 Timestamp: 2024-07-05T00:02:36.493Z Learning: The `CreateSignerObserverEVM` function in `zetaclient/orchestrator/chain_activate.go` is covered by unit tests in `zetaclient/orchestrator/chain_activate_test.go`.Learnt from: ws4charlie PR: zeta-chain/node#2411 File: zetaclient/orchestrator/orchestrator.go:192-217 Timestamp: 2024-07-04T23:46:38.428Z Learning: The `GetUpdatedSigner` method in `zetaclient/orchestrator/orchestrator.go` is covered by unit tests in `zetaclient/orchestrator/chain_activate_test.go` and `zetaclient/orchestrator/orchestrator_test.go`.Learnt from: ws4charlie PR: zeta-chain/node#2411 File: zetaclient/orchestrator/chain_activate.go:184-247 Timestamp: 2024-07-05T00:02:31.446Z Learning: The `CreateSignerObserverBTC` function in `zetaclient/orchestrator/chain_activate.go` is covered by unit tests in `zetaclient/orchestrator/chain_activate_test.go`.
GitHub Check: codecov/patch
zetaclient/chains/evm/signer/gas.go
[warning] 38-43: zetaclient/chains/evm/signer/gas.go#L38-L43
Added lines #L38 - L43 were not covered by testszetaclient/chains/evm/signer/outbound_data.go
[warning] 64-64: zetaclient/chains/evm/signer/outbound_data.go#L64
Added line #L64 was not covered by tests
[warning] 85-85: zetaclient/chains/evm/signer/outbound_data.go#L85
Added line #L85 was not covered by tests
[warning] 90-92: zetaclient/chains/evm/signer/outbound_data.go#L90-L92
Added lines #L90 - L92 were not covered by tests
[warning] 95-96: zetaclient/chains/evm/signer/outbound_data.go#L95-L96
Added lines #L95 - L96 were not covered by tests
[warning] 100-103: zetaclient/chains/evm/signer/outbound_data.go#L100-L103
Added lines #L100 - L103 were not covered by tests
[warning] 111-111: zetaclient/chains/evm/signer/outbound_data.go#L111
Added line #L111 was not covered by tests
[warning] 142-142: zetaclient/chains/evm/signer/outbound_data.go#L142
Added line #L142 was not covered by testszetaclient/chains/evm/signer/signer.go
[warning] 182-182: zetaclient/chains/evm/signer/signer.go#L182
Added line #L182 was not covered by tests
[warning] 217-217: zetaclient/chains/evm/signer/signer.go#L217
Added line #L217 was not covered by tests
[warning] 231-240: zetaclient/chains/evm/signer/signer.go#L231-L240
Added lines #L231 - L240 were not covered by tests
[warning] 426-426: zetaclient/chains/evm/signer/signer.go#L426
Added line #L426 was not covered by tests
[warning] 519-519: zetaclient/chains/evm/signer/signer.go#L519
Added line #L519 was not covered by tests
[warning] 528-528: zetaclient/chains/evm/signer/signer.go#L528
Added line #L528 was not covered by tests
[warning] 543-543: zetaclient/chains/evm/signer/signer.go#L543
Added line #L543 was not covered by tests
[warning] 554-554: zetaclient/chains/evm/signer/signer.go#L554
Added line #L554 was not covered by tests
[warning] 562-562: zetaclient/chains/evm/signer/signer.go#L562
Added line #L562 was not covered by tests
[warning] 576-576: zetaclient/chains/evm/signer/signer.go#L576
Added line #L576 was not covered by tests
[warning] 592-592: zetaclient/chains/evm/signer/signer.go#L592
Added line #L592 was not covered by tests
Additional comments not posted (40)
zetaclient/chains/evm/signer/gas.go (6)
13-16: Constants for gas limits look good.The defined constants for
minGasLimitandmaxGasLimitare reasonable and appropriate for EVM transactions.
18-34: Struct definition looks good.The
Gasstruct is well-defined with appropriate fields and helpful comments.
36-46: Validation function is well-implemented but lacks test coverage.The
validatefunction correctly checks for invalid states in theGasstruct. However, the added lines are not covered by tests.Ensure that test cases are added to cover the
validatefunction.Tools
GitHub Check: codecov/patch
[warning] 38-43: zetaclient/chains/evm/signer/gas.go#L38-L43
Added lines #L38 - L43 were not covered by tests
49-55: Legacy check function is well-implemented.The
isLegacyfunction correctly determines if the transaction is a legacy transaction based on thePriorityFee.
57-96: Gas creation function is well-implemented but ensure comprehensive test coverage.The
makeGasFromCCTXfunction correctly creates aGasstruct from a cross-chain transaction with proper error handling and logging. However, ensure that test cases cover all branches of the function.Ensure comprehensive test coverage for all branches of the
makeGasFromCCTXfunction.
99-113: Big integer parsing function is well-implemented.The
bigIntFromStringfunction correctly parses a string into abig.Intand handles various edge cases appropriately.zetaclient/chains/evm/signer/outbound_data_test.go (8)
27-56: Success test case is well-implemented.The "success" test case follows the Arrange-Act-Assert pattern and includes comprehensive assertions to verify the integrity of the created outbound data.
59-72: Pending revert test case is well-implemented.The "pending revert" test case correctly sets up the transaction status and includes assertions to verify the expected behavior.
74-86: Pending outbound test case is well-implemented.The "pending outbound" test case correctly sets up the transaction status and includes assertions to verify the expected behavior.
89-98: Skip inbound test case is well-implemented.The "skip inbound" test case correctly sets up the transaction status and includes assertions to verify the expected behavior.
102-112: Skip aborted test case is well-implemented.The "skip aborted" test case correctly sets up the transaction status and includes assertions to verify the expected behavior.
115-125: Invalid gas price test case is well-implemented.The "invalid gas price" test case correctly sets up the invalid gas price and includes assertions to verify the expected error message.
127-136: Unknown chain test case is well-implemented.The "unknown chain" test case correctly sets up the unknown chain and includes assertions to verify the expected error message.
138-147: No outbound params test case is well-implemented.The "no outbound params" test case correctly sets up the missing parameters and includes assertions to verify the expected error message.
zetaclient/chains/evm/signer/gas_test.go (11)
32-41: Legacy: gas is too low test case is well-implemented.The "legacy: gas is too low" test case correctly sets up the gas limit and includes assertions to verify the expected behavior.
44-53: London: gas is too low test case is well-implemented.The "london: gas is too low" test case correctly sets up the gas limit and includes assertions to verify the expected behavior.
56-65: Pre London gas logic test case is well-implemented.The "pre London gas logic" test case correctly sets up the gas parameters and includes assertions to verify the expected behavior.
68-77: Post London gas logic test case is well-implemented.The "post London gas logic" test case correctly sets up the gas parameters and includes assertions to verify the expected behavior.
80-89: Gas is too high, force to the ceiling test case is well-implemented.The "gas is too high, force to the ceiling" test case correctly sets up the gas limit and includes assertions to verify the expected behavior.
92-95: Priority fee is invalid test case is well-implemented.The "priority fee is invalid" test case correctly sets up the invalid priority fee and includes assertions to verify the expected error message.
97-100: Priority fee is negative test case is well-implemented.The "priority fee is negative" test case correctly sets up the negative priority fee and includes assertions to verify the expected error message.
102-105: Gas price is less than priority fee test case is well-implemented.The "gasPrice is less than priorityFee" test case correctly sets up the gas price and priority fee and includes assertions to verify the expected error message.
107-110: Gas price is invalid test case is well-implemented.The "gasPrice is invalid" test case correctly sets up the invalid gas price and includes assertions to verify the expected error message.
125-129: Utility function for asserting gas equality is well-implemented.The
assertGasEqualsfunction correctly compares the expected and actualGasstructs, ensuring accurate comparisons of the fields.
131-134: **Utility function for Gweizetaclient/chains/evm/signer/outbound_data.go (2)
Line range hint
24-43:
LGTM!The
OutboundDatastruct has been updated with a newGastype and reorganization of fields. These changes enhance clarity and maintainability.
44-137: Ensure comprehensive test coverage.The
NewOutboundDatafunction has been updated with enhanced error handling and logging. Ensure that all new lines, especially error handling paths, are covered by tests.Would you like assistance in generating additional unit tests to cover the new lines?
Verification successful
Ensure comprehensive test coverage.
The
NewOutboundDatafunction has been updated with enhanced error handling and logging. The function is well-integrated and covered by tests insigner_test.goandoutbound_data_test.go, ensuring that all new lines, especially error handling paths, are tested.
- File:
zetaclient/chains/evm/signer/signer_test.go- File:
zetaclient/chains/evm/signer/outbound_data_test.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of `NewOutboundData` function in the codebase. # Test: Search for the function usage. Expect: Occurrences of the new signature. rg --type go -A 5 $'NewOutboundData'Length of output: 6557
Tools
GitHub Check: codecov/patch
[warning] 64-64: zetaclient/chains/evm/signer/outbound_data.go#L64
Added line #L64 was not covered by tests
[warning] 85-85: zetaclient/chains/evm/signer/outbound_data.go#L85
Added line #L85 was not covered by tests
[warning] 90-92: zetaclient/chains/evm/signer/outbound_data.go#L90-L92
Added lines #L90 - L92 were not covered by tests
[warning] 95-96: zetaclient/chains/evm/signer/outbound_data.go#L95-L96
Added lines #L95 - L96 were not covered by tests
[warning] 100-103: zetaclient/chains/evm/signer/outbound_data.go#L100-L103
Added lines #L100 - L103 were not covered by tests
[warning] 111-111: zetaclient/chains/evm/signer/outbound_data.go#L111
Added line #L111 was not covered by testszetaclient/chains/evm/signer/signer_test.go (10)
Line range hint
200-204:
LGTM!The invocation of
NewOutboundDatainTestSigner_SignOutboundhas been updated. The changes are consistent with the new function signature.
Line range hint
236-240:
LGTM!The invocation of
NewOutboundDatainTestSigner_SignRevertTxhas been updated. The changes are consistent with the new function signature.
Line range hint
276-280:
LGTM!The invocation of
NewOutboundDatainTestSigner_SignCancelTxhas been updated. The changes are consistent with the new function signature.
Line range hint
316-320:
LGTM!The invocation of
NewOutboundDatainTestSigner_SignWithdrawTxhas been updated. The changes are consistent with the new function signature.
Line range hint
354-358:
LGTM!The invocation of
NewOutboundDatainTestSigner_SignCommandTxhas been updated. The changes are consistent with the new function signature.
Line range hint
401-405:
LGTM!The invocation of
NewOutboundDatainTestSigner_SignERC20WithdrawTxhas been updated. The changes are consistent with the new function signature.
Line range hint
442-446:
LGTM!The invocation of
NewOutboundDatainTestSigner_BroadcastOutboundhas been updated. The changes are consistent with the new function signature.
579-583: LGTM!The
makeCtxfunction has been updated to include an additional chain in the context setup. This change enhances the testing scope.
Line range hint
499-503:
LGTM!The invocation of
NewOutboundDatainTestSigner_SignWhitelistERC20Cmdhas been updated. The changes are consistent with the new function signature.
Line range hint
544-548:
LGTM!The invocation of
NewOutboundDatainTestSigner_SignMigrateTssFundsCmdhas been updated. The changes are consistent with the new function signature.zetaclient/chains/evm/signer/signer.go (2)
243-247: LGTM!The
Broadcastmethod has been renamed tobroadcast. The changes are consistent with the intended usage.
763-766: Ensure comprehensive test coverage.The
SignCommandTxmethod has been updated to use the newGasstructure. Ensure that all new lines,changelog.md (1)
49-49: Ensure consistency in changelog entry formatting.The new entry follows the correct format and provides a clear description of the new feature. No issues found.
lumtis
added
UPGRADE_TESTS
@ws4charlie what do you think? As of now:
Doesn't ETH RPC take London fork into account when executing SuggestGasPrice() aka |
I think The |
This reverts commit 2260925.
… into feat/zetaclient/eip-1559
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
Hello, buddy, I want to know how to contact you. I am interested in the oxygen you developed, but I don’t understand some of the installation steps. Can I ask you for help? |
* Add Gas struct * Add EIP-1559 fees * Update changelog * Add test cases for legacy vs dynamicFee txs * Fix typo; Add E2E coverage * Address PR comments * Address PR comments * Use gasFeeCap formula * Revert "Use gasFeeCap formula" This reverts commit 2260925. * Address PR comments * Fix e2e upgrade tests
* Add Gas struct * Add EIP-1559 fees * Update changelog * Add test cases for legacy vs dynamicFee txs * Fix typo; Add E2E coverage * Address PR comments * Address PR comments * Use gasFeeCap formula * Revert "Use gasFeeCap formula" This reverts commit 2260925. * Address PR comments * Fix e2e upgrade tests
* Add Gas struct * Add EIP-1559 fees * Update changelog * Add test cases for legacy vs dynamicFee txs * Fix typo; Add E2E coverage * Address PR comments * Address PR comments * Use gasFeeCap formula * Revert "Use gasFeeCap formula" This reverts commit 2260925. * Address PR comments * Fix e2e upgrade tests
* feat: parse inscription like witness data (#2524) * parse inscription like witness data * more comment * remove unused code * Update zetaclient/chains/bitcoin/tx_script.go Co-authored-by: Dmitry S <11892559+swift1337@users.noreply.github.com> * Update zetaclient/chains/bitcoin/observer/inbound.go Co-authored-by: Dmitry S <11892559+swift1337@users.noreply.github.com> * Update zetaclient/chains/bitcoin/tx_script.go Co-authored-by: Dmitry S <11892559+swift1337@users.noreply.github.com> * Update zetaclient/chains/bitcoin/tx_script.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * pull origin * Update zetaclient/chains/bitcoin/observer/inbound.go Co-authored-by: Dmitry S <11892559+swift1337@users.noreply.github.com> * review feedbacks * update review feedbacks * update make generate * fix linter * remove over flow * Update zetaclient/chains/bitcoin/observer/inbound.go Co-authored-by: Francisco de Borja Aranda Castillejo <me@fbac.dev> * Update zetaclient/chains/bitcoin/tokenizer.go Co-authored-by: Francisco de Borja Aranda Castillejo <me@fbac.dev> * Update zetaclient/chains/bitcoin/tokenizer.go Co-authored-by: Francisco de Borja Aranda Castillejo <me@fbac.dev> * Update zetaclient/chains/bitcoin/tokenizer.go Co-authored-by: Francisco de Borja Aranda Castillejo <me@fbac.dev> * Update zetaclient/chains/bitcoin/tokenizer.go Co-authored-by: Francisco de Borja Aranda Castillejo <me@fbac.dev> * update review feedback * update code commnet * update comment * more comments * Update changelog.md --------- Co-authored-by: Dmitry S <11892559+swift1337@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Francisco de Borja Aranda Castillejo <me@fbac.dev> fix version * feat: detect memo in btc txn from OP_RETURN and inscription (#2533) * parse inscription like witness data * more comment * remove unused code * parse inscription * Update zetaclient/chains/bitcoin/tx_script.go Co-authored-by: Dmitry S <11892559+swift1337@users.noreply.github.com> * Update zetaclient/chains/bitcoin/observer/inbound.go Co-authored-by: Dmitry S <11892559+swift1337@users.noreply.github.com> * Update zetaclient/chains/bitcoin/tx_script.go Co-authored-by: Dmitry S <11892559+swift1337@users.noreply.github.com> * Update zetaclient/chains/bitcoin/tx_script.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * pull origin * Update zetaclient/chains/bitcoin/observer/inbound.go Co-authored-by: Dmitry S <11892559+swift1337@users.noreply.github.com> * review feedbacks * update review feedbacks * add mainnet txn * Update zetaclient/chains/bitcoin/tx_script.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * parse inscription like witness data * more comment * remove unused code * Update zetaclient/chains/bitcoin/tx_script.go Co-authored-by: Dmitry S <11892559+swift1337@users.noreply.github.com> * Update zetaclient/chains/bitcoin/observer/inbound.go Co-authored-by: Dmitry S <11892559+swift1337@users.noreply.github.com> * Update zetaclient/chains/bitcoin/tx_script.go Co-authored-by: Dmitry S <11892559+swift1337@users.noreply.github.com> * Update zetaclient/chains/bitcoin/tx_script.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * pull origin * Update zetaclient/chains/bitcoin/observer/inbound.go Co-authored-by: Dmitry S <11892559+swift1337@users.noreply.github.com> * review feedbacks * update review feedbacks * update make generate * fix linter * remove over flow * Update zetaclient/chains/bitcoin/observer/inbound.go Co-authored-by: Francisco de Borja Aranda Castillejo <me@fbac.dev> * Update zetaclient/chains/bitcoin/tokenizer.go Co-authored-by: Francisco de Borja Aranda Castillejo <me@fbac.dev> * Update zetaclient/chains/bitcoin/tokenizer.go Co-authored-by: Francisco de Borja Aranda Castillejo <me@fbac.dev> * Update zetaclient/chains/bitcoin/tokenizer.go Co-authored-by: Francisco de Borja Aranda Castillejo <me@fbac.dev> * Update zetaclient/chains/bitcoin/tokenizer.go Co-authored-by: Francisco de Borja Aranda Castillejo <me@fbac.dev> * update review feedback * update code commnet * update comment * more comments * Update changelog.md * Update zetaclient/chains/bitcoin/observer/inbound.go Co-authored-by: Francisco de Borja Aranda Castillejo <me@fbac.dev> * Update zetaclient/chains/bitcoin/observer/inbound.go Co-authored-by: Francisco de Borja Aranda Castillejo <me@fbac.dev> * clean up * format code --------- Co-authored-by: Dmitry S <11892559+swift1337@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Francisco de Borja Aranda Castillejo <me@fbac.dev> * refactor(zetaclient)!: improve AppContext (#2568) * Implement chain registry * Rewrite test-cases for AppContext * Drop `supplychecker` * Refactor app ctx Update worker * Refactor orchestrator * Refactor observer&signer; DROP postBlockHeaders * Fix test cases [1] * Update changelog * Allow Zeta Chain in appContext; address PR comments [1] * Fix app context update * Check for `chain.IsZeta()` * Add AppContext.FilterChains * Fix test cases [2] * Fix test cases [3] * Address PR comments [1] * Address PR comments [2] * Add tests for `slices` * Fix e2e tests [1] * Fix e2e tests [2] * Resolve conflicts, converge codebase between PRs * Add lodash; remove slices pkg * Address PR comments * Minor logging fix * Address PR comments tmp * feat(zetaclient): add generic rpc metrics (#2597) * feat(zetaclient): add generic rpc metrics * feedback * changelog * fmt * fix(zetaclient): use name in pending tx metric (#2642) * feat(pkg): add `ticker` package (#2617) * Add `pkg/ticker` * Sample ticker usage in evm observer * Change naming * Address PR comments * Address PR comments * feat(zetaclient)!: Add support for EIP-1559 gas fees (#2634) * Add Gas struct * Add EIP-1559 fees * Update changelog * Add test cases for legacy vs dynamicFee txs * Fix typo; Add E2E coverage * Address PR comments * Address PR comments * Use gasFeeCap formula * Revert "Use gasFeeCap formula" This reverts commit 2260925. * Address PR comments * Fix e2e upgrade tests * fix: adjust evm outbound tracker reporter to avoid submitting invalid hashes (#2628) * refactor and fix evm outbound tracker reporter to avoid invalid hashes; print log when outbound tracker is full of invalid hashes * add changelog entry * used predefined log fields * remove repeated fields information from log message; Devops team would configure Datadog to show the fields * remove redundant fields in log message; unified logs * remove pending transaction map from observer; the outbound tracker reporter will no longer report pending hash * use bg.Work() to launch outbound tracker reporter goroutines * bring the checking EnsureNoTrackers() back * add more rationale to EVM outbound tracker submission * sync observer and signers without wait on startup * try fixing tss migration E2E failure by increase timeout * feat: Solana relayer (fee payer) key importer, encryption and decryption (#2673) * configure observer relayer key for Solana; remove hardcoded solana test key from zetaclient code * implementation of relayer key importer, encryption and decryption * integrate relayer key into E2E and Solana signer * add relayer_key_balance metrics and unit tests * use TrimSpace to trim password * add changelog entry * use relayer account array in E2E config; a few renaming; add private key validation when importing * fix linter * remove GetNetworkName method for simplification * added PromptPassword method to prompt single password * use network name as map index to store relayer key passwords * moved relayer passwords to chain registry * airdrop SOL token only if solana local node is available --------- Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * ci: Set Docker Workflow to use Go 1.22 (#2722) * Set go 1.22.2 * Set go 1.22.2 * Set go 1.22 * Set go 1.22 * Refactor contrib/rpc and contrib/docker-scripts to use snapshots API (#2724) Co-authored-by: Julian Rubino <julian@zetachain.com> --------- Co-authored-by: dev-bitSmiley <153714963+bitSmiley@users.noreply.github.com> Co-authored-by: Dmitry S <11892559+swift1337@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Francisco de Borja Aranda Castillejo <me@fbac.dev> Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> Co-authored-by: Charlie <31941002+CharlieMc0@users.noreply.github.com> Co-authored-by: Julian Rubino <julian.rubino0@gmail.com> Co-authored-by: Julian Rubino <julian@zetachain.com>
This PR concludes EIP-1559 implementation for outbound transactions. The flow
ethtypes.DynamicFeeTx{}withGasTipCapinstead ofethtypes.LegacyTx{}Closes #1952. This is a rewrite of #2387
Summary by CodeRabbit
New Features
Bug Fixes
Tests
Documentation