Remove hidden TaggableInterface dependencies from paginator #7181
Conversation
| $tags = static::$cache->getTags($key); | ||
| if ($tags && in_array($this->_getCacheInternalId(), $tags)) { | ||
| if (substr($key, 0, $prefixLength) == self::CACHE_TAG_PREFIX) { | ||
| static::$cache->removeItem($this->_getCacheId((int)substr($key, $prefixLength))); |
There was a problem hiding this comment.
It works also with static::$cache->removeItem($key);. Is there a reason to do it this way?
There was a problem hiding this comment.
From reading the code, this ensures that the page number is properly injected into the key.
hver
changed the title
|
I'm not sure, why the Travis build on PHP 5.4 fails on |
|
Those tests are sadly time-bound, and tend to fail when the travis
|
Remove hidden TaggableInterface dependencies from paginator
|
Merged to develop for release with 2.4. |
…or-cache-interfaces Remove hidden TaggableInterface dependencies from paginator
This is an example for discussion on issue #7174 Cache in Paginator module supports only
MemoryandFilesystemadapters