Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

The display_exceptions config-option is not passed to 404 views. #3477

Closed
wants to merge 2 commits into from

Conversation

androa
Copy link
Contributor

@androa androa commented Jan 18, 2013

Fixes zendframework/ZendSkeletonApplication#155

When setting display_exceptions to true the exception is injected to the 404 view, but not the display_exception option.

weierophinney added a commit that referenced this pull request Jan 21, 2013
@weierophinney
Copy link
Member

While not technically necessary (you could test to see if $this->exception is an Exception), I think this makes sense. Merged.

@ghost ghost assigned weierophinney Jan 21, 2013
@androa
Copy link
Contributor Author

androa commented Jan 21, 2013

Yeah, I considered that first, but then you will be unable to say "No exception available" when display_exceptions is on and by some insane reason there is no exception. No biggie but choose this way to be consistent with how other exceptions are handled.

weierophinney notifications@github.com:

While not technically necessary (you could test to see if $this->exception is an Exception), I think this makes sense. Merged.


Reply to this email directly or view it on GitHub.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The display_exceptions config-option is not passed to views
2 participants