Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Allow usage of Reader without GooglePlayPodcast extension #81

Conversation

weierophinney
Copy link
Member

Custom implementations of ExtensionManagerInterface may not have new core extensions present. As a result, when upgrading, an exception is thrown due to inability to load the new extension.

This was discovered with the 2.10 release, when we added a new core extension, GooglePlayPodcast; see #80 and https://www.drupal.org/project/drupal/issues/2976335 for more details.

As such, we now check for new core extensions before registering them. When we discover they are not in the extension manager, we emit an E_USER_NOTICE indicating the user should update their ExtensionManagerInterface implementation to add entries for the new extension, but then continue on without registering the extension. This ensures no exception is thrown.

@weierophinney
Copy link
Member Author

Test failures are all due to network timeouts when testing remote feed parsing.

Custom implementations of `ExtensionManagerInterface` may not have _new
core_ extensions present. As a result, when upgrading, an exception is
thrown due to inability to load the new extension.

This was discovered with the 2.10 release, when we added a new core
extension, GooglePlayPodcast; see zendframework#80 and https://www.drupal.org/project/drupal/issues/2976335
for more details.

As such, we now check for _new_ core extensions before registering them.
When we discover they are not in the extension manager, we emit an
`E_USER_NOTICE` indicating the user should update their
`ExtensionManagerInterface` implementation to add entries for the new
extension, but then continue on without registering the extension. This
ensures no exception is thrown.
@weierophinney weierophinney force-pushed the hotfix/google-play-podcast-extension-entry branch from 2c09572 to dfbb10f Compare June 18, 2018 16:53
…t extension

This patch adapts the same pattern used in the `Reader` subcomponent
with regards to conditionally loading newly introduced extensions to the
`Writer` subcomponent: if the extension manager does not know of the
extension, it is not registered, and an `E_USER_NOTICE` is emitted
prompting the developer to add entries to their extension manager
implementation.
@weierophinney weierophinney merged commit bfd6b1a into zendframework:master Jun 18, 2018
weierophinney added a commit that referenced this pull request Jun 18, 2018
weierophinney added a commit that referenced this pull request Jun 18, 2018
@weierophinney weierophinney deleted the hotfix/google-play-podcast-extension-entry branch June 18, 2018 20:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant