Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Patch for <itunes:image> in entries #77

Merged
merged 2 commits into from
May 24, 2018
Merged

Patch for <itunes:image> in entries #77

merged 2 commits into from
May 24, 2018

Conversation

podcasthosting
Copy link

This implements feature request #76

@froschdesign
Copy link
Member

@OpenHaus
Please add always unit tests for new features.

Thanks!

OpenHaus and others added 2 commits May 24, 2018 09:38
… will provide output

The itunes:image tag may be used both at the podcast feed and episode
level, so support needs to be in both locations.

This also means that the renderers for each need to output the tag.
@weierophinney weierophinney changed the base branch from master to develop May 24, 2018 15:04
@weierophinney
Copy link
Member

@OpenHaus — I've changed the target branch to develop (since this is a new feature), rebased your branch based on that, and added tests. I also ensured both the entry and feed renderers will emit the tag now.

@weierophinney
Copy link
Member

@OpenHaus I've also added itunes:image support within the reader for entries/episodes. We previously supported it at the feed level only, but the spec allows both.

@weierophinney weierophinney merged commit 4ff8b54 into zendframework:develop May 24, 2018
weierophinney added a commit that referenced this pull request May 24, 2018
weierophinney added a commit that referenced this pull request May 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants