This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Setting a title of '0' will cause an exception to be thrown #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add unit tests for this use case. Thanks! |
…l be thrown. This change will still reject strings that are truly empty, but now accept a string value of '0'. This might feel a bit edge case, but we've seen it in production hence the PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a string of '0' is provided as a title, an exception will be thrown.
This change will still reject strings that are truly empty, but now accept a string value of '0'.
This might feel a bit edge case, but we've seen it in production hence the PR.