This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
fix warning 'Parameter must be an array or an object that implements … #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Countable' (PHP 7.2)
remicollet
force-pushed
the
issue-php72
branch
from
b178e34
to
e50e94d
Compare
|
I use the Test suite only raise this warning in |
|
@remicollet All changes I can see are: - if (count($result)) {
+ if ($result && count($result)) {Wouldn't be enough to have just: if ($result) {? |
|
@webimpress no idea, I don't now enough the whole stack involved here, so I just copy/paste a previously used test. |
|
@remicollet it seems we need both, because it is an object, not a 'normal' array... :) |
weierophinney
added a commit
that referenced
this pull request
Dec 4, 2017
fix warning 'Parameter must be an array or an object that implements …
weierophinney
added a commit
that referenced
this pull request
Dec 4, 2017
weierophinney
added a commit
that referenced
this pull request
Dec 4, 2017
|
Thanks, @remicollet |
weierophinney
added a commit
that referenced
this pull request
Dec 4, 2017
PHP 7.2 + QA Tools + Docs - follow up #50 Conflicts: composer.json composer.lock
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Countable' (PHP 7.2)
Discovered in Fedora QA
https://apps.fedoraproject.org/koschei/package/php-zendframework-zend-feed?collection=f28