This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Fix to make withPort fully compliant with PSR-7 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
withPort should allow null port
|
Missing test |
weierophinney
added a commit
that referenced
this pull request
Oct 15, 2015
Fix to make withPort fully compliant with PSR-7
weierophinney
added a commit
that referenced
this pull request
Oct 15, 2015
weierophinney
added a commit
that referenced
this pull request
Oct 15, 2015
| @@ -88,7 +89,7 @@ public function testWithPortReturnsNewInstanceWithProvidedPort($port) | |||
| $this->assertNotSame($uri, $new); | |||
| $this->assertEquals($port, $new->getPort()); | |||
| $this->assertEquals( | |||
| sprintf('https://user:pass@local.example.com:%d/foo?bar=baz#quz', $port), | |||
| sprintf('https://user:pass@local.example.com%s/foo?bar=baz#quz', $port === null ? '' : ':'.$port), | |||
There was a problem hiding this comment.
Its preferible provide the expected values as part of the data provider. What test verify this branch of logic test as expected?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withPort should allow null port