This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Remove methods declared as deprecated on 0.7.0 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ServerRequestFactory::marshalHostAndPort and ServerRequestFactory::marshalUriFromServer was declared as deprecated before the first stable release of the project.
|
Yes, they were deprecated prior to the stable release, but they should not be removed within a maintenance release. I'm rescheduling this to 1.1, and will merge to the develop branch. |
weierophinney
added a commit
that referenced
this pull request
Jun 4, 2015
Remove methods declared as deprecated on 0.7.0
weierophinney
added a commit
that referenced
this pull request
Jun 4, 2015
weierophinney
added a commit
that referenced
this pull request
Jun 4, 2015
- Noted the removal of the two methods.
|
Merged to develop for release with 1.1.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServerRequestFactory::marshalHostAndPort and ServerRequestFactory::marshalUriFromServer was declared as deprecated before the first stable release of the project.