This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Reverts extension of SplFileInfo #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Post-release, users discovered problems with `UploadedFile` extending `SplFileInfo`, particularly when a stream path is used to create the instance. Additionally, there are some differences with how `UploadedFileInterface` and `SplFileInfo` each define the return type for `getSize()`; the former allows nullification, while the latter does not, but allows raising an exception (something explicitly disallowed in PSR-7). This patch reverts the code and documentation changes associated with the patch.
froschdesign
approved these changes
Nov 13, 2019
ADmad
approved these changes
Nov 13, 2019
weierophinney
added a commit
that referenced
this pull request
Nov 13, 2019
weierophinney
added a commit
that referenced
this pull request
Nov 13, 2019
…nto develop Forward port #379 Conflicts: CHANGELOG.md
weierophinney
deleted the
feature/revert-uploadedfile-extension-of-splfileinfo
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post-release of 2.2.0, users discovered problems with
UploadedFileextendingSplFileInfo, particularly when a stream path is used to create the instance. Additionally, there are some differences with howUploadedFileInterfaceandSplFileInfoeach define the return type forgetSize(); the former allows nullification, while the latter does not, but allows raising an exception (something explicitly disallowed in PSR-7).This patch reverts the code and documentation changes associated with the patch.