This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Declare strict_types and use STH/RTH #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds RTH and scalar type hints wherever possible. However, in many cases, because we are implementing interfaces, we cannot provide parameter type hints without conflicting with the interface; return type hints are allowed, though, due to PHP's contravariant return type rules. Constructors always add parameter types, however, which eliminates the need for many unit tests, as well as type checks within the constructors. A number of additional code changes were made due to enabling strict types. In some cases, we were returning values that we should not have been based on the return signature. In other cases, we were not casting values before passing them to functions or methods, and should have.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds RTH and scalar type hints wherever possible. However, in many cases, because we are implementing interfaces, we cannot provide parameter type hints without conflicting with the interface; return type hints are allowed, though, due to PHP's contravariant return type rules.
Constructors always add parameter types, however, which eliminates the need for many unit tests, as well as type checks within the constructors.
A number of additional code changes were made due to enabling strict types. In some cases, we were returning values that we should not have been based on the return signature. In other cases, we were not casting values before passing them to functions or methods, and should have.