This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Alternate fixes #192 #197
Merged
Alternate fixes #192 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| { | ||
| $uri = (new Uri())->withHost('google.com'); | ||
| $this->assertEquals('google.com', (string) $uri); | ||
| $this->assertNotEquals('google.com:', (string) $uri); |
There was a problem hiding this comment.
Is it make a sense if you have a assertEquals?
There was a problem hiding this comment.
yes, I can remove if requested
weierophinney
added a commit
that referenced
this pull request
Sep 7, 2016
Alternate fixes #192 Conflicts: test/UriTest.php
weierophinney
added a commit
that referenced
this pull request
Sep 7, 2016
|
Thanks, @samsonasik. I made the change suggested by @snapshotpl on merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate fixes #192