This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Added stream rewind in JsonResponse constructor #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for reporting this and providing a patch! I was about to merge, and realized the issue was also present in the HTML and text response types! I'm updating those as part of the merge. |
weierophinney
added a commit
that referenced
this pull request
Dec 16, 2015
Added stream rewind in JsonResponse constructor
weierophinney
added a commit
that referenced
this pull request
Dec 16, 2015
The same issue observed in the `JsonResponse` was also present in the `HtmlResponse` and `TextResponse`: the constructor was not rewinding the body after creation, meaning `getContents()` was starting from the end of the stream. Each now has tests for this behavior, and the constructor logic now rewinds the body stream after creation.
weierophinney
added a commit
that referenced
this pull request
Dec 16, 2015
|
Thanks for very fast fixes. @weierophinney When new version will be released? |
|
@NikolaySl Already done; 1.3.1 has the fixes. |
|
@weierophinney how are we supposed to write to the stream afterwards since it has been rewinded? Let's say we have a middleware that adds additional content to the stream, |
|
Moved my question to #195, it affects all response classes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.