This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Simplify status code #103
Merged
Simplify status code #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->assertEquals($expected, $response->getHeaders()); | ||
| } | ||
|
|
||
| /** | ||
| * @expectedException \InvalidArgumentException |
There was a problem hiding this comment.
Please follow the same convention as the rest of tests. Use setExpectedException and fill the second argument.
|
What purpose does a null status code serve? I honestly do not understand the rationale behind this change. |
|
What he say is the argument should be always integer however the actual code implemented allow null |
weierophinney
added a commit
that referenced
this pull request
Dec 15, 2015
weierophinney
added a commit
that referenced
this pull request
Dec 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to simplify set status code. Why? Constructor's phpdocs says that it's expected
$statusvariable as int, not null, only int. I know that make BC, however it should be done in my opinion