Merge pull request zendframework/zendframework#5569 from michaelmouss…

…a/readable-config-arrays

Fixed boolean/integer BC break in Zend\Config\Writer\PhpArray

src/Writer/PhpArray.php

@@ -78,8 +78,12 @@ protected function processIndented(array $config, array $arraySyntax, &$indentLe
                 }
             } elseif (is_object($value)) {
                 $arrayString .= var_export($value, true) . ",\n";
-            } else {
+            } else if (is_bool($value)) {
+                $arrayString .= ($value ? 'true' : 'false') . ",\n";
+            } elseif (is_string($value)) {
                 $arrayString .= "'" . addslashes($value) . "',\n";
+            } else {
+                $arrayString .= $value . ",\n";
             }
         }
 

test/Writer/PhpArrayTest.php

@@ -35,7 +35,9 @@ public function testRender()
             'test' => 'foo',
             'bar' => array(0 => 'baz', 1 => 'foo'),
             'emptyArray' => array(),
-            'object' => (object) array('foo' => 'bar')
+            'object' => (object) array('foo' => 'bar'),
+            'integer' => 123,
+            'boolean' => false,
         ));
 
         $configString = $this->writer->toString($config);
@@ -52,6 +54,8 @@ public function testRender()
         $expected .= "    'object' => stdClass::__set_state(array(\n";
         $expected .= "   'foo' => 'bar',\n";
         $expected .= ")),\n";
+        $expected .= "    'integer' => 123,\n";
+        $expected .= "    'boolean' => false,\n";
         $expected .= ");\n";
 
         $this->assertEquals($expected, $configString);