CI #508
Merged
CI #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests: 258, Assertions: 2278, Failures: 3, Errors: 6. 1 test commented
ecoologic
force-pushed
the
RED-1950-docker
branch
from
6eba821
to
bcceb81
Compare
ecoologic
force-pushed
the
RED-1950-docker
branch
from
bcceb81
to
c897efe
Compare
ecoologic
force-pushed
the
RED-1950-docker
branch
from
7e1a8c1
to
11c938c
Compare
ecoologic
force-pushed
the
RED-1950-docker
branch
2 times, most recently
from
f71062a
to
f5428c6
Compare
ecoologic
commented
Oct 6, 2023
| @@ -1,6 +1,9 @@ | |||
| <?php | |||
|
|
|||
| // TODO: Don't fail using deprecated code | |||
| // error_reporting(E_ALL ^ E_DEPRECATED); | |||
| error_reporting(- 1); | |||
There was a problem hiding this comment.
I will allow the use of deprecated code, at least as a milestone, but if I do that now the tests keep going and breaks the whole test execution, so I'll do that separately.
yoshdog
reviewed
Oct 6, 2023
| @@ -36,7 +36,7 @@ public function testExceptionsRetry($exception, $success) | |||
| } | |||
| ]; | |||
| $client = $this->mockApiResponses([ | |||
| new $exception('', new Request('GET', '')), | |||
| new $exception('', new Request('GET', ''), new Response()), | |||
yoshdog
approved these changes
Oct 6, 2023
|
🥳 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a decent milestone and a good time to split the work. Usually I don't leave
TODOsin PRs but I will follow up with another PR to solve those issues.There's more than 6 tests to fix, the tough ones, but less than a dozen.