Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare dependency on guzzlehttp/psr7 #476

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Conversation

wouterj
Copy link
Contributor

@wouterj wouterj commented Oct 29, 2021

This package uses functions from guzzlehttp/psr7, which are removed in psr7 2.0. As no dependency was declared, it was possible to install psr7 2.0 together with this package, resulting in fatal errors. By declaring the dependency, we can limit psr7 to 1.x.

After #469 is merged, the version constraint can be updated to ^1.7 || ^2.0 (as the static method API used in that PR was introduced in 1.7.0).

@yoshdog yoshdog merged commit 5e1146f into zendesk:master Jan 5, 2022
@wouterj wouterj deleted the patch-1 branch January 5, 2022 08:20
@GrahamCampbell
Copy link

Guzzle maintainer here. You should instead upgrade to replacement functions. They are available on 1.x and 2.x.

@wouterj
Copy link
Contributor Author

wouterj commented Jan 11, 2022

@GrahamCampbell yes, both actions should be done (declare dependency if you depend on something the package provides & use the BC layer for 2.0). That's what I meant with (#469 is doing the method replacement):

After #469 is merged, the version constraint can be updated to ^1.7 || ^2.0 (as the static method API used in that PR was introduced in 1.7.0).

Seems like this was forgotten, I've submitted a new PR to fix the constraint: #480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants