Sidebar layout fixes #1875
Sidebar layout fixes #1875
Conversation
| } | ||
|
|
||
| /* Expanded */ | ||
| #navigator-toolbox:is( |
There was a problem hiding this comment.
I dont really understand this change, why not just add it at the top with the rest?
There was a problem hiding this comment.
You're right. I removed it
| display: flex; | ||
| flex-direction: column; | ||
| gap: 0 !important; | ||
|
|
||
| margin-bottom: 8px; | ||
| position: relative; | ||
|
|
||
| &:has(tab:not([hidden]))::after { | ||
| &::after { |
There was a problem hiding this comment.
Why remove this? It's supposed to be only a separator when there's pinned tabs
There was a problem hiding this comment.
I just moved up, because when there wore no pinned tabs, the 8px margin-bottom wore still being applied causing an alignment difference between collapsed and expanded.
- #vertical-pinned-tabs-container {
+ #vertical-pinned-tabs-container:has(tab:not([hidden])) {Now when there is no pinned tab, there will be no separator nor margin
| #navigator-toolbox[zen-expanded='true']:not([zen-user-hover='true']))) { | ||
| & #tabbrowser-tabs { | ||
| & .tabbrowser-tab { | ||
| width: unset !important; |
There was a problem hiding this comment.
This woudnt make the tabs look squared, no?
There was a problem hiding this comment.
This prevent the tab to immediately shrink to its min width (36px) when no longer hovering
Without this it would look like this when collapsing:
| Without it | With it |
|---|---|
Screen.Recording.2024-10-03.at.14.16.51.mov |
Screen.Recording.2024-10-03.at.14.16.36.mov |
DanielSRS
force-pushed
the
sidebar_layout_fixes
branch
from
51a5c7a
to
e14e69b
Compare
|
It looks better |
|
I dont even know what's going on, too many changes |
DanielSRS
force-pushed
the
sidebar_layout_fixes
branch
from
e14e69b
to
562b956
Compare
DanielSRS
force-pushed
the
sidebar_layout_fixes
branch
from
562b956
to
b4c7e65
Compare
|
You say the compare after I force pushed? I did a rebase with main. The last changes in main created conflicts, so I rebased to solve them. Other than that as you pointed out:
I removed the unneeded code and moved it to the top. |
before - after
Screen.Recording.2024-10-02.at.19.23.47.mov