PauseMenuDataMgr: use better variable names #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoetlino
reviewed
Aug 30, 2023
|
also please fix the clang-format failure -- either run clang-format to reformat the code automatically, or reformat it manually by doing what it tells you to do. |
leoetlino
reviewed
Aug 31, 2023
Co-authored-by: Léo Lam <leo@leolam.fr>
Co-authored-by: Léo Lam <leo@leolam.fr>
leoetlino
approved these changes
Sep 3, 2023
There was a problem hiding this comment.
Thanks, this looks good! Just one last thing: Could you rename mArrayTabs to mTabs and mArrayTabsType to mTabTypes? I put "array" in the placeholder name because otherwise it wasn't obvious that those variables were arrays, but now that we know those are tabs/tab types we don't need to keep "array" in the names.
Sure, no problem, mArrayTabs and mArrayTabsTypes becomes mTabs and mTabsTypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't made any changes before so please tell me if I make any mistakes
This change is