Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSI packaging script using wix #12298

Closed

Conversation

jakobhellermann
Copy link
Contributor

implements #12288

Add a simple wix package for building an MSI that

  • installs Zed to Program Files
  • Open with Zed menu in the file explorer

image

Open questions

  1. the installer currently uncontionally installs the "Open with handler", should this be configurable? there's a wixui feature tree we could use https://wixtoolset.org/docs/tools/wixext/wixui/
  2. do you wanna sign the installer? no idea how that works but I heard you might get a certificate from signpath.io for free for larger open source projects Documentation on signing Windows and MacOS apps sigstore/fulcio#250 (comment) https://signpath.org/

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label May 25, 2024
@JunkuiZhang
Copy link
Contributor

I guess this is something that should leave to zed staff. And personally I prefer Inno Setup, since VSCode uses it.

@jakobhellermann
Copy link
Contributor Author

I guess this is something that should leave to zed staff. And personally I prefer Inno Setup, since VSCode uses it.

Yep at the end of the day it's up to zed staff. I personally like wix because it outputs a MSI which is the native installer format. As far as I can tell, inno setup would produce a ZedInstaller.exe instead.

@mikayla-maki
Copy link
Contributor

Thank you for this contribution, but I don't think we want to go this far streamlining windows support until we have staff able to support our windows build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants