Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark UI theme and custom theme support #1124

Closed
wants to merge 1 commit into from

Conversation

kaygdev
Copy link
Contributor

@kaygdev kaygdev commented Jul 31, 2019

Enable user CSS and dark mode for the UI from the settings dialog. Fix some graphics issue with dark mode described in #466.

For the dark mode is used the dark orange stylesheet from http://discourse.techart.online/t/release-qt-dark-orange-stylesheet/2287 with small modifications.

@kaygdev kaygdev requested a review from trollixx as a code owner July 31, 2019 22:34
@JARVIS-AI
Copy link

Did you test it ? (Run it with your changes)

@trollixx
Copy link
Member

Bundling unmaintained styles is not a good idea. Any operating system or Qt update will potentially break it. Also it would require extensive testing on various systems with different settings.

If something in Zeal breaks custom styles, that needs to be addressed, and I'd be happy to accept such changes, but otherwise styles should not be part of the project.

There's a ticket #811 about supporting dark window style.

Copy link
Member

@trollixx trollixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be revised to only contain changes required for custom styles to work, but not specific to any style.

@0xboz
Copy link

0xboz commented May 20, 2020

I was trying to add the setup I used (Debian 10), but it was closed by the bot. I guess I will just leave it here in case someone comes across later.

sudo apt install qt5-style-plugins
echo "export QT_QPA_PLATFORMTHEME=gtk2" >> ~/.profile

Log out and log back in. Here is the result (on Debian 10 + Gnome + Flat Remix GTK )

zeal-dark-theme-debian-gnome cleaned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants