Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update markdown2 dependency #2154

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

thetableman
Copy link
Contributor

This PR changes the dependency requirements for markdown2 in response to the issue raised in #2153

Copy link
Contributor

@falkoschindler falkoschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @thetableman! Looks good. 🙂

@falkoschindler falkoschindler added the bug Something isn't working label Dec 11, 2023
@falkoschindler falkoschindler added this to the 1.4.6 milestone Dec 11, 2023
@falkoschindler falkoschindler merged commit 25df06a into zauberzeug:main Dec 11, 2023
1 check passed
@thetableman thetableman deleted the update_dependency branch December 21, 2023 21:39
sscherfke added a commit to sscherfke/nicegui that referenced this pull request Feb 3, 2024
- The "^" specifier is often too restrictive for 0.* versions so I would
  not recommend to use it in these cases:
  https://python-poetry.org/docs/dependency-specification/
- Markdown2: The issue from 2.4.11 was fixed in 2.4.12:
  - zauberzeug#2154
  - trentm/python-markdown2#546
  - https://github.com/trentm/python-markdown2/blob/master/CHANGES.md#python-markdown2-2412
- Watchfiles: Doesn't look like v1 will introduce breaking changes:
  samuelcolvin/watchfiles#186
- python-multipart: "^0.06" is "==0.0.6" which is too strict and
  at this stage, any release can potentially add breaking changes
- aiofiles: Uses CalVer and 24.0.0 is as likely to introduce breaking
  changes as 23.2.0.
- httpx: It does not look like 1.0.0 will introduce breaking changes
  (if you already fixed any deprecation warnings).  Testing against the
  1.0.0beata0 is advisable, though.
  encode/httpx#3069
- ifaddr: Development is rather slow, package looks quite stable.
  I don't think that a 0.3.0 will add breaking changes and a 1.0 is not
  in sight.
- pytest-asyncio: Restriction to >=0.19,<0.20 seems unwanted and updates
  are needed for recent pytest versions
- pytest: Has there been a reason to not support pytest7?  pytest8
  currently breaks some plugins, but this should be fixed soon.

Fixes: zauberzeug#2485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatting incorrect in ui.markdown with markdown2==2.4.11
2 participants