feat: header options for WS and REST #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 178e3be The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
IdkGoodName
commented
Apr 21, 2024
There was a problem hiding this comment.
Not related to the PR as much, but I also believe we could just modify the client options to use RestOptions and WebSocketOptions for rest and ws properties respectively, since it's directly given to RestManager and WebSocketManager. Otherwise, there may be hacky casts.
|
Sorta requested by @zaida04. |
zaida04
approved these changes
Apr 21, 2024
zaida04
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
headersto options to both WS and REST to allow easier access to Guilded API experiments today and in the future. This also adds client optionwsthat will be handed to the WebSocket directly (which is what is done to REST as of now).Status
Semantic versioning classification: