Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure 'Got' to use HttpsProxyAgent for https URLs #428

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

etemi
Copy link
Contributor

@etemi etemi commented Aug 6, 2024

Configure 'Got' to use HttpsProxyAgent for https URLs
(e.g. when default protolint host is used as in https://github.com/yoheimuta/protolint/releases/download/....)

Related to #427

@carstencodes I would really appreciate it if you could take a look at it.

Copy link
Contributor

@carstencodes carstencodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Owner

@yoheimuta yoheimuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to both of you for the fix.

@yoheimuta yoheimuta merged commit 6cc254e into yoheimuta:master Aug 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants