Allow to restore original pushed message class on consume #214
Conversation
| @@ -18,6 +18,7 @@ public function serialize(MessageInterface $message): string | |||
| 'name' => $message->getHandlerName(), | |||
| 'data' => $message->getData(), | |||
| 'meta' => $message->getMetadata(), | |||
| 'class' => $message instanceof EnvelopeInterface ? $message->getMessage()::class : $message::class, | |||
There was a problem hiding this comment.
Am I correct that class name is in the data that is sent? If so, I'd avoid that. Is that possible to use a plain envelope name, not a class?
There was a problem hiding this comment.
It's a message class. It may be used only by an application which pushed this message to the queue. I'll move this data to the "meta" key. Anyway this data is not usable by another services.
| @@ -113,7 +115,7 @@ public function testSerialize(): void | |||
| $json = $serializer->serialize($message); | |||
|
|
|||
| $this->assertEquals( | |||
| '{"name":"handler","data":"test","meta":[]}', | |||
| '{"name":"handler","data":"test","meta":[],"class":"Yiisoft\\\\Queue\\\\Message\\\\Message"}', | |||
There was a problem hiding this comment.
Can we use a map of name => class somewhere (probably hardcoded in the envelope itself)? I'd avoid PHP-specific FQNs at all costs.
There was a problem hiding this comment.
This class is specific to an application which pushes a message to a queue. This class list is not usable by any other service. I'll move this class to the "meta" key.
This PR allows you to push your own message class and then get it back after it was consumed.
See new tests for details.