Fix bug and test

yiisoft · Sep 20, 2024 · 2bb91ad · 2bb91ad
1 parent 02f2534
commit 2bb91ad
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/Message/AbstractEnvelope.php b/src/Message/AbstractEnvelope.php
@@ -26,8 +26,11 @@ public function __construct(MessageInterface $message)
 
         if (is_array($this->metadata[EnvelopeInterface::ENVELOPE_STACK_KEY])) {
             $this->metadata[EnvelopeInterface::ENVELOPE_STACK_KEY] = array_merge(
-                [static::class],
                 $envelopes,
+                array_filter(
+                    $this->metadata[EnvelopeInterface::ENVELOPE_STACK_KEY],
+                    static fn (string $envelope): bool => !in_array($envelope, $envelopes),
+                ),
             );
         } else {
             $this->metadata[EnvelopeInterface::ENVELOPE_STACK_KEY] = [static::class];

diff --git a/tests/Unit/Message/JsonMessageSerializerTest.php b/tests/Unit/Message/JsonMessageSerializerTest.php
@@ -66,7 +66,7 @@ public function testUnserializeFromData(): void
 
         $this->assertInstanceOf(MessageInterface::class, $message);
         $this->assertEquals($payload['data'], $message->getData());
-        $this->assertEquals([], $message->getMetadata());
+        $this->assertEquals([EnvelopeInterface::ENVELOPE_STACK_KEY => []], $message->getMetadata());
     }
 
     public function testUnserializeWithMetadata(): void
@@ -78,7 +78,10 @@ public function testUnserializeWithMetadata(): void
 
         $this->assertInstanceOf(MessageInterface::class, $message);
         $this->assertEquals($payload['data'], $message->getData());
-        $this->assertEquals(['int' => 1, 'str' => 'string', 'bool' => true], $message->getMetadata());
+        $this->assertEquals(
+            ['int' => 1, 'str' => 'string', 'bool' => true, EnvelopeInterface::ENVELOPE_STACK_KEY => []],
+            $message->getMetadata()
+        );
     }
 
     public function testUnserializeEnvelopeStack(): void