Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

在{FIT,GPX,TCX}_OUT三个文件夹添加数据文件出发同步脚本 #451

Closed

Conversation

agassiyzh
Copy link
Collaborator

  1. FIT_OUT,GPX_OUT,TCX_OUT三个文件夹添加数据文件后,添加了三个action,出发相应的sync脚本。

  2. CI中的提交commit message前都加上了[skip ci],可以表明CI抓取数据后的push导致出发上面的action。

  3. garmin_sync添加了--only-doowload参数。可以只下载数据。

@vercel
Copy link

vercel bot commented Jul 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
running-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2023 5:21pm

@yihong0618
Copy link
Owner

why not add all of them in run_data_sync.yml?

@agassiyzh
Copy link
Collaborator Author

why not add all of them in run_data_sync.yml?

确实考虑在run_data_sync.yml一个文件中完成。
但是在job.step的条件判断中没有找到path判断。

@agassiyzh
Copy link
Collaborator Author

why not add all of them in run_data_sync.yml?

想到一个方案。我改改添加个提交

Copy link
Owner

@yihong0618 yihong0618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他的实现没问题

Comment on lines 9 to +15
workflow_dispatch:
schedule:
- cron: '0 0 * * *'
push:
branches:
- master
paths:
- scripts/nike_sync.py
- scripts/nike_to_strava_sync.py
- scripts/strava_sync.py
- scripts/gen_svg.py
- scripts/garmin_sync.py
- scripts/keep_sync.py
- scripts/gpx_sync.py
- scripts/tcx_sync.py
- scripts/garmin_to_strava_sync.py
- requirements.txt
inputs:
logLevel:
description: 'run type'
required: true
default: 'pass'
type: choice
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不建议改这块的逻辑,因为我们用户一大部分没有编程基础,他们是网上找的教程,这块会变得不一样。而且老用户 merge master 逻辑也会变

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果有这个考虑。这个PR关掉了。似乎找不到更好的方式实现这个需求。

@agassiyzh agassiyzh closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants