1539, Phone.Systems account Service provisioner #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivanov-Anton
force-pushed
the
1539-phonesystems-account-service-provisioner
branch
5 times, most recently
from
799faf4
to
262f39a
Compare
Ivanov-Anton
force-pushed
the
1539-phonesystems-account-service-provisioner
branch
2 times, most recently
from
4b05d5f
to
4f19a0a
Compare
|
better to name it Billing::Provisioning::PhoneSystems |
|
@dmitry-sinina what should be when Admin updates Billing::Service and update their variables, I mean should system perform the PATCH request to phone.system in such case? For example update language from EN to LT |
Ivanov-Anton
force-pushed
the
1539-phonesystems-account-service-provisioner
branch
from
4f19a0a
to
ad12ec7
Compare
… on telecom.center side
Ivanov-Anton
force-pushed
the
1539-phonesystems-account-service-provisioner
branch
from
ad12ec7
to
3ba0507
Compare
currently I think it will do nothing. In future we have to implement "resync" action on service and if provisioner supports this resync it will do updates. but I think it will be in next merge request |
Ivanov-Anton
added
Waiting for code review
Ivanov-Anton
deleted the
1539-phonesystems-account-service-provisioner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Phone.Systems account Service provisioner
Additional links
closes #1539