1516, do not raise error when Node return not found #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within Jobs::CallsMonitoring job we execute the terminate_calls! method and within this method sometime Node returns "not found" response and in this case do not raise error NodeApi::Error and no not send exception in Sentry.
Ivanov-Anton
deleted the
1516_do_not_raise_error_when_node_return_not_fount
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within Jobs::CallsMonitoring job we execute the terminate_calls! method and within this method sometime Node returns "not found" response and in this case do not raise error NodeApi::Error and no not send exception in Sentry.
closes #1516