allow to ContactEmailSender to create email log even when there is SMTP setting #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivanov-Anton
force-pushed
the
YETI-WEB-1395-AccountBalanceNotify
branch
2 times, most recently
from
e7df11b
to
95144f9
Compare
Ivanov-Anton
commented
Jul 17, 2024
| @@ -23,7 +23,6 @@ | |||
| expect { subject }.to change { Log::EmailLog.count }.by(1) | |||
| email_log = Log::EmailLog.last! | |||
| expect(email_log).to have_attributes(expected_email_log_attrs) | |||
| expect(Worker::SendEmailLogJob).to have_been_enqueued.with(email_log.id) | |||
There was a problem hiding this comment.
removed because at the 31 line we have already perform this test
Ivanov-Anton
force-pushed
the
YETI-WEB-1395-AccountBalanceNotify
branch
2 times, most recently
from
d098026
to
3dc28e7
Compare
Ivanov-Anton
force-pushed
the
YETI-WEB-1395-AccountBalanceNotify
branch
from
3dc28e7
to
0e052ab
Compare
Ivanov-Anton
added
the
Waiting for code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when we perform
ContactEmailSender.batch_send_emails(contacts, subject: 'text', message: 'message')the Email log is not created due there is no any SMTP configs even global
To imptove this logic I suggest to remove
not nullconstraint frommail_fromcolumn ofnotifications.email_logstable and do not fill in this column when we performbatch_send_emailsmethod.As result we will able to view Email Log (Logs->Email Log) and determinate that curently there is no any SMTP config and it should be created for specific contact or Global one.
Additional links
closes #1395