Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworking mkDebounce #996

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Vlix
Copy link
Contributor

@Vlix Vlix commented Jun 8, 2024

Ok, so I've tried to rework the debouncing, because of issue #980, but it seems to fail on a test because the trigger MVar doesn't seem to be correctly filled unless I put a trace in a specific spot!?

Does anyone know how to force/evaluate (or whatever is happening here) the tryPutMVar without using trace?

  • auto-update: reworked 'mkDebounce', and it should work... but 'Leading' only works if I put a 'trace' in a specific spot???

Still TODO:

  • Bumped the version number

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

…ng' only works if I put a 'trace' in a specific spot???
@Vlix Vlix requested a review from kazu-yamamoto June 8, 2024 21:21
@Vlix
Copy link
Contributor Author

Vlix commented Jun 9, 2024

Hmmm, seeing the random failing in CI jobs, this is probably a timing issue? And the trace "..." printing to the screen just takes enough time with the GHC version I was developing with? 🤔

Now to figure out if the test should be adjusted, or if there is actually an error in the implementation...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant