Fixes global cache #5739
Merged
Fixes global cache #5739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
commented
Sep 15, 2023
| xfs.writeJsonSync(ppath.join(temp, Filename.manifest), { | ||
| name: `benchmark`, | ||
| private: true, | ||
| runExit(class extends Command { |
There was a problem hiding this comment.
Added two features here to make benchmarking easier: bench-import <name> will copy the benchmark manifest from one of the presets, and --branch can be used to test the current build against a different branch or commit than just master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The cache fix merged in #5730 had a bug that caused the global cache to be skipped when a package had no checksum - which happens when there are no lockfile in the project. This was detected by the perf regression visible on the dashboard:
How did you fix it?
I fixed the condition (it was "use the cache if there's a checksum and it's compatible", it should have been "use the cache if there's no checksum, or it's a compatible one") and added tests to avoid further regressions.
Checklist