Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements enableOfflineMode #5710

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Implements enableOfflineMode #5710

merged 1 commit into from
Sep 14, 2023

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Sep 1, 2023

What's the problem this PR addresses?

We didn't have a good story for people performing local development on their projects while under network-constrained environments. I'm myself working from trains from time to time, and each time it always come a point where I want to do a quick repro with one package or another, but since I don't have network it's a pain.

How did you fix it?

A new enableOfflineMode setting tells Yarn to reuse the metadata stored in the cache, even if they may be stale (a good feature reuse of the logic @paul-soporan's originally made for perf reasons!).

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 9c3dc22 into master Sep 14, 2023
17 checks passed
@arcanis arcanis deleted the mael/train-2-offline branch September 14, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant