Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase timeout #5612

Merged
merged 1 commit into from
Jul 26, 2023
Merged

test: increase timeout #5612

merged 1 commit into from
Jul 26, 2023

Conversation

paul-soporan
Copy link
Member

What's the problem this PR addresses?

In 90% of PRs, there's at least one check failing due to a few random tests exceeding timeout.

Unfortunately, that isn't helpful at all as it doesn't indicate anything useful. If something could be implemented more efficiently, we'll definitely get an issue about it at some point - timeouts only prevent us from merging PRs and can hide actual issues since it might make us skip checking why a check is failing and assume it's the timeout.

How did you fix it?

Increased the timeout on LE systems from 50 seconds to 75 seconds.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

Copy link
Member

@merceyz merceyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should update

testTimeout: 50000,
as well or remove it if it doesn't do anything.

@paul-soporan
Copy link
Member Author

That one affects the unit tests and I don't think we've ever had problems with them timing out 🤔

Copy link
Member

@merceyz merceyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough.

@paul-soporan paul-soporan added this pull request to the merge queue Jul 26, 2023
Merged via the queue into master with commit db16d64 Jul 26, 2023
15 checks passed
@paul-soporan paul-soporan deleted the paul/test/increase-timeout branch July 26, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants