Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-npm): normalize registry #5582

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jul 15, 2023

What's the problem this PR addresses?

While working on #5581 I noticed that we're not normalizing the registry passed to the npmHttpUtils methods.
There are tests that are supposed to catch this but the mock wasn't reset before each test so they didn't.

How did you fix it?

Normalize the registry and update the tests to use wrapNetworkRequest.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 9b79bfe into master Jul 18, 2023
15 checks passed
@arcanis arcanis deleted the merceyz/fix/normalize-registry branch July 18, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants