Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: compute Node.js build target from engines.node #5554

Merged
merged 2 commits into from
Jul 2, 2023
Merged

chore: compute Node.js build target from engines.node #5554

merged 2 commits into from
Jul 2, 2023

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jul 1, 2023

What's the problem this PR addresses?

Whenever we change the supported Node.js version we have to manually update the build target in multiple files.

Ref #5445 (review)

How did you fix it?

Automate it by computing the Node.js version to target for the builds with semver.minVersion and engines.node.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit e9826af into master Jul 2, 2023
15 checks passed
@arcanis arcanis deleted the merceyz/chore/node-target branch July 2, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merceyz @arcanis