Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix tsconfig excludes #5525

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jun 24, 2023

What's the problem this PR addresses?

The exclude pattern packages/*/{lib,bin,bundles} in the tsconfig.json file doesn't work.

How did you fix it?

Split it out into separate entries.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 30b0d09 into master Jun 26, 2023
15 checks passed
@arcanis arcanis deleted the merceyz/chore/fix-tsconfig-exclude branch June 26, 2023 08:53
merceyz added a commit that referenced this pull request Jun 30, 2023
**What's the problem this PR addresses?**

The exclude pattern `packages/*/{lib,bin,bundles}` in the
`tsconfig.json` file doesn't work.

**How did you fix it?**

Split it out into separate entries.

**Checklist**
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).
- [x] I have set the packages that need to be released for my changes to
be effective.
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants