perf: use buffer.isUtf8 in NodePathFS
#5516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-soporan
commented
Jun 22, 2023
| @@ -140,8 +140,7 @@ export function getCaller() { | |||
|
|
|||
| export function availableParallelism() { | |||
| // TODO: Use os.availableParallelism directly when dropping support for Node.js < 19.4.0 | |||
| if (`availableParallelism` in os) | |||
| // @ts-expect-error - No types yet | |||
| if (typeof os.availableParallelism !== `undefined`) | |||
There was a problem hiding this comment.
Changed this check because otherwise os would have been never in the other branch.
merceyz
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Node 18.14.0 added a new function:
buffer.isUtf8How did you fix it?
I've tested it and it's 75 times faster than our current implementation.
For an
80 MBbuffer:315.447ms4.06msChecklist